Allow retrieving all registered provider IDs from registry #79
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@JasonTheAdams The change you made assumes this is supposed to return provider class names, but I was intending for it to return provider IDs, per the method name. So something is not right here now, one way or another. Should we maybe add methods for both? |
|
Oh goodness, my bad. I saw the Why not have it return the |
IMO too low-level. I think methods for exactly what you want (one or the other) are more intuitive. |
|
@felixarntz Works for me! In that case, lets stick with what you have. The dev can use Sorry for messing it up. 😆 |
|
I put it back to how you had it when I first approved. So let's just pretend I wasn't "helpful" and merge this bad boy. 😂 |
Our registry so far does not allow this, but it's a crucial requirement IMO. Code needs to be able to cycle through all registered providers, e.g. in our WordPress specific package this need is already relevant.