Removes system message concept #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
approved these changes
Aug 23, 2025
Comment on lines
-947
to
+944
| +setSystemInstruction(string|MessagePart|MessagePart[]|Message $systemInstruction) void | ||
| +getSystemInstruction() Message? | ||
| +setSystemInstruction(string $systemInstruction) void | ||
| +getSystemInstruction() string? |
There was a problem hiding this comment.
Regarding this change, I was wondering whether your PR was missing that adjustment in ModelConfig itself, but then I checked and realized we never implemented it like this in the first place, it's always been a string - so that's perfect 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion with @felixarntz, we decided that having both system instructions in the
ModelConfigand aSystemMessagewithinMessagearrays is confusing. This was the case because some model APIs treat system instructions as a configuration, while others expect it as the first message. But trying to do both in a client intended to be a unified API is confusing — both for the Extender and for the Implementor.This PR removes the concept of the system message in favor of system instructions as part of the
ModelConfig. This just focuses on how it's removed. Using the instructions in the config will be reflected in subsequent PRs.