Skip to content

Run PHPCS on unit tests as well #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

Run PHPCS on unit tests as well #40

merged 2 commits into from
Aug 5, 2025

Conversation

@felixarntz
Copy link
Member

This PR does two things:

  • Ensure tests are covered by PHPCS as well. While not everything necessarily applies for tests, our checks so far are very basic and make sense to be consistently applied.
  • Remove the odd test restriction to 8 parallel files, which actually led to only 8 files being linted when running composer phpcs.

@felixarntz felixarntz added the [Type] Enhancement A suggestion for improvement. label Aug 5, 2025
JasonTheAdams
JasonTheAdams approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! ✨

@JasonTheAdams JasonTheAdams merged commit 61af8b6 into trunk Aug 5, 2025
4 checks passed
@felixarntz felixarntz added this to the Finish the foundation milestone Aug 13, 2025
@felixarntz felixarntz deleted the enhance/phpcs-tests branch August 14, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

Assignees

No one assigned

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Finish the foundation

Development

Successfully merging this pull request may close these issues.

3 participants

@felixarntz @JasonTheAdams