Skip to content

Conversation

@borkweb
Copy link
Contributor

@borkweb borkweb commented Jul 12, 2025

Excludes development and documentation files from Composer package:

  • Development configs (.editorconfig, .gitignore, .gitattributes)
  • GitHub workflows
  • Documentation folder
  • Test files and configs
  • Vendor directory

This is, of course, excluding things that are not yet part of the repository but will likely be part of it soon.

Excludes development and documentation files from Composer package:
- Development configs (.editorconfig, .gitignore, .gitattributes)
- GitHub workflows
- Documentation folder
- Test files and configs
- Vendor directory

This is, of course, excluding things that are not yet part of the repository but will likely be part of it soon.
@felixarntz felixarntz added the [Tool] Issues related to development tooling, such as linting, testing, or CI label Jul 12, 2025
@JasonTheAdams
Copy link
Member

I'm a touch reluctant to preemptively include things like /docs/, as I'm not aware of that even being discussed yet. But others, like tests, are probably fine.

@borkweb
Copy link
Contributor Author

borkweb commented Jul 13, 2025

I can count on one hand the number of times I've personally looked at documentation in a vendor folder. That number is zero 😁

Ultimately, I can modify it however we want - I was mimicking Guzzle's repo.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @borkweb! Two points of feedback, plus a higher level question: What is the rationale for prefixing some root files with forward slashes while not prefixing others? What's the distinction?

@borkweb
Copy link
Contributor Author

borkweb commented Jul 14, 2025

What is the rationale for prefixing some root files with forward slashes while not prefixing others? What's the distinction?

Any non prefixed item will apply to that file/directory anywhere in the repo. Technically git observes .gitignore and .gitattributes within nested directories and the rules cascade down recursively. For .editorconfig, that gives a project the ability to set different standards in a different directory.

That being said, it is unlikely that those will occur in this repo and we can prefix if we want. I just left them unprefixed because of habit.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borkweb LGTM, just a tiny bit before merge.

@felixarntz felixarntz merged commit 43ef024 into WordPress:trunk Jul 14, 2025
@felixarntz felixarntz added this to the Finish the foundation milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] Issues related to development tooling, such as linting, testing, or CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants