-
Notifications
You must be signed in to change notification settings - Fork 34
Add .gitattributes for package distribution #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Excludes development and documentation files from Composer package: - Development configs (.editorconfig, .gitignore, .gitattributes) - GitHub workflows - Documentation folder - Test files and configs - Vendor directory This is, of course, excluding things that are not yet part of the repository but will likely be part of it soon.
|
I'm a touch reluctant to preemptively include things like |
|
I can count on one hand the number of times I've personally looked at documentation in a vendor folder. That number is zero 😁 Ultimately, I can modify it however we want - I was mimicking Guzzle's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @borkweb! Two points of feedback, plus a higher level question: What is the rationale for prefixing some root files with forward slashes while not prefixing others? What's the distinction?
Co-authored-by: Felix Arntz <flixos90@gmail.com>
…into add/gitattributes
Any non prefixed item will apply to that file/directory anywhere in the repo. Technically git observes That being said, it is unlikely that those will occur in this repo and we can prefix if we want. I just left them unprefixed because of habit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@borkweb LGTM, just a tiny bit before merge.
Excludes development and documentation files from Composer package:
This is, of course, excluding things that are not yet part of the repository but will likely be part of it soon.