Skip to content

Updates preferred model tests to avoid passing by default #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
+12 −9
Merged

Updates preferred model tests to avoid passing by default #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions tests/unit/Builders/PromptBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,8 +728,9 @@ public function testUsingModelPreferenceWithProviderTupleModelInstanceThrowsExce
public function testUsingModelPreferencePrefersFirstAvailableModelId(): void
{
$result = $this->createTestResult('Preferred by ID');
$metadata = $this->createTextModelMetadataWithInputSupport('preferred-id');
$model = $this->createMockTextGenerationModel($result, $metadata);
$secondaryMetadata = $this->createTextModelMetadataWithInputSupport('secondary-id');
$preferredMetadata = $this->createTextModelMetadataWithInputSupport('preferred-id');
$model = $this->createMockTextGenerationModel($result, $preferredMetadata);

$this->registry->expects($this->once())
->method('getProviderId')
Expand All @@ -739,7 +740,7 @@ public function testUsingModelPreferencePrefersFirstAvailableModelId(): void
$this->registry->expects($this->once())
->method('findProviderModelsMetadataForSupport')
->with('test-provider', $this->isInstanceOf(ModelRequirements::class))
->willReturn([$metadata]);
->willReturn([$secondaryMetadata, $preferredMetadata]);

$this->registry->expects($this->once())
->method('getProviderModel')
Expand All @@ -766,8 +767,9 @@ public function testUsingModelPreferencePrefersFirstAvailableModelId(): void
public function testUsingModelPreferenceWithProviderClassName(): void
{
$result = $this->createTestResult('Preferred with class name');
$metadata = $this->createTextModelMetadataWithInputSupport('preferred-id');
$model = $this->createMockTextGenerationModel($result, $metadata);
$secondaryMetadata = $this->createTextModelMetadataWithInputSupport('secondary-id');
$preferredMetadata = $this->createTextModelMetadataWithInputSupport('preferred-id');
$model = $this->createMockTextGenerationModel($result, $preferredMetadata);

$this->registry->expects($this->once())
->method('getProviderId')
Expand All @@ -777,7 +779,7 @@ public function testUsingModelPreferenceWithProviderClassName(): void
$this->registry->expects($this->once())
->method('findProviderModelsMetadataForSupport')
->with('WordPress\AiClient\TestProvider', $this->isInstanceOf(ModelRequirements::class))
->willReturn([$metadata]);
->willReturn([$secondaryMetadata, $preferredMetadata]);

$this->registry->expects($this->once())
->method('getProviderModel')
Expand All @@ -804,8 +806,9 @@ public function testUsingModelPreferenceWithProviderClassName(): void
public function testUsingModelPreferenceSkipsUnavailableModelId(): void
{
$result = $this->createTestResult('Fallback model result');
$metadata = $this->createTextModelMetadataWithInputSupport('fallback-id');
$model = $this->createMockTextGenerationModel($result, $metadata);
$otherMetadata = $this->createTextModelMetadataWithInputSupport('other-id');
$fallbackMetadata = $this->createTextModelMetadataWithInputSupport('fallback-id');
$model = $this->createMockTextGenerationModel($result, $fallbackMetadata);

$this->registry->expects($this->once())
->method('getProviderId')
Expand All @@ -815,7 +818,7 @@ public function testUsingModelPreferenceSkipsUnavailableModelId(): void
$this->registry->expects($this->once())
->method('findProviderModelsMetadataForSupport')
->with('test-provider', $this->isInstanceOf(ModelRequirements::class))
->willReturn([$metadata]);
->willReturn([$otherMetadata, $fallbackMetadata]);

$this->registry->expects($this->once())
->method('getProviderModel')
Expand Down