Fix image focal point bug when dominant color is enabled by not overriding style attribute#582
Merged
felixarntz merged 7 commits intotrunkfrom Nov 16, 2022
Merged
Conversation
mukeshpanchal27
added
[Type] Bug
mukeshpanchal27
requested review from
pbearne and
spacedmonkey
as code owners
pbearne
approved these changes
Nov 15, 2022
mehulkaklotar
approved these changes
Nov 15, 2022
Member
mehulkaklotar
left a comment
mehulkaklotar
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 LGTM 🚀
3 tasks
felixarntz
reviewed
Nov 15, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Production code implementation looks good, could you please add a unit test to cover that the change works correctly though?
felixarntz
changed the title
felixarntz
changed the title
felixarntz
changed the title
style attribute
felixarntz
changed the title
style attributestyle attribute
3 tasks
costdev
reviewed
Nov 16, 2022
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
costdev
reviewed
Nov 16, 2022
costdev
reviewed
Nov 16, 2022
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
costdev
approved these changes
Nov 16, 2022
Contributor
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback! LGTM now 👍
felixarntz
approved these changes
Nov 16, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Great, tests looks solid too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #562
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.