Skip to content

Scaffold View Transitions feature plugin #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

felixarntz
Copy link
Member

Summary

See #1997.

Relevant technical choices

  • This is the first of several PRs to implement the first version of the plugin.
  • This PR only scaffolds the basics and opts the site in to using view transitions, controlled via theme support.
  • Subsequent PRs will add more advanced functionality, like view transition names, different transition types, and different animations.
  • This PR does not add the plugin to plugins.json, since it should not be released yet until all work for Implement View Transitions feature plugin #1997 has been completed.

Copy link

github-actions bot commented Apr 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz added [Type] Feature A new feature within an existing module [Plugin] View Transitions Issues for the View Transitions plugin no milestone PRs that do not have a defined milestone for release labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base (ff8b62b) to head (f75b6b1).
Report is 3 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/view-transitions/hooks.php 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1998   +/-   ##
=======================================
  Coverage   72.51%   72.52%           
=======================================
  Files          85       87    +2     
  Lines        7023     7036   +13     
=======================================
+ Hits         5093     5103   +10     
- Misses       1930     1933    +3     
Flag Coverage Δ
multisite 72.52% <76.92%> (+<0.01%) ⬆️
single 40.40% <76.92%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixarntz felixarntz merged commit 27592d1 into trunk Apr 30, 2025
16 checks passed
@felixarntz felixarntz deleted the add/scaffold-view-transitions-plugin-basics branch April 30, 2025 23:21

Contributors: wordpressdotorg
Tested up to: 6.8
Stable tag: 1.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, I'll fix this as part of #1999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] View Transitions Issues for the View Transitions plugin [Type] Feature A new feature within an existing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants