-
Notifications
You must be signed in to change notification settings - Fork 112
Remove sizes attribute when responsive images are disabled #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As WordPress core does not add sizes attribute for thumbnail size, In e83ac2d i have to remove it from tests. Is there any specific reason for it 🤔 |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
were tests failing without this change?
I was wondering as well. Maybe for HDPI versions of thumbnails (x2) if that were a thing? For picture element we want srcset for fallbacks, but not sure why we would want sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@westonruter @adamsilverstein or @swissspidy Could you please review and merge it. Thanks! |
Summary
Fixes #1389
Check the issue description for testing details.