Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issues link on the about page #758

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #567 by @krysal

Description

Updates the "issue" link on the about page to point to the issues landing page. This is much clearer for users who do not already have a GitHub account or who aren't logged in.

Testing Instructions

Go to the /about page locally and click the "issue" link. Observe you are taken to the catalog issue list.

Checklist

  • My pull request has a descriptive title
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner February 22, 2023 15:08
@github-actions github-actions bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 22, 2023
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't solve the problem but it's much better for the user than seeing a GitHub login screen without explanation. LGTM!

@zackkrida
Copy link
Member Author

We do also suggest 'sending an email' after the suggestion to create a GitHub issue. Email should be accessible and low-tech enough for most people, I think.

@github-actions
Copy link

Playwright failure test results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for all playwright tests that have failed at the bottom of this page, under the
"Artifacts" section:

https://github.com/WordPress/openverse/actions/runs/4244082120

Read more about how to use this artifact here: https://github.com/WordPress/openverse/blob/main/frontend/test/playwright/README.md#debugging

@zackkrida zackkrida changed the title Update issues link on the sources page Update issues link on the sources and about pages Feb 22, 2023
@zackkrida zackkrida changed the title Update issues link on the sources and about pages Update issues link on the about page Feb 22, 2023
@github-actions
Copy link

Playwright failure test results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for all playwright tests that have failed at the bottom of this page, under the
"Artifacts" section:

https://github.com/WordPress/openverse/actions/runs/4244082120

Read more about how to use this artifact here: https://github.com/WordPress/openverse/blob/main/frontend/test/playwright/README.md#debugging

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 24, 2023
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do also suggest 'sending an email' after the suggestion to create a GitHub issue. Email should be accessible and low-tech enough for most people, I think.

Yeah, thinking again, that seems sufficient for people not knowledgeable of GitHub and find the template for New Provider issues more valuable than linking to the GitHub issues page as well 😅 Perhaps we don't need to change anything here!

@zackkrida zackkrida merged commit 6d949e1 into main Feb 28, 2023
@zackkrida zackkrida deleted the fix-meta-copy-issues-link branch February 28, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an issue link on the meta search page goes to a GitHub auth page for non-GitHub users
4 participants