Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append concurrency tag to prevent issues between DAGs in staging #5155

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 8, 2024

Fixes

Fixes #5128 by @stacimc

Description

This PR adds the missing STAGING_DB_CONCURRENCY_TAG to the staging data refresh DAG to prevent it from running with conflicting DAGs like the staging database restore.

It also gives the index of the wait_for_external_dag mapped tasks a friendlier name than the default numbers. Now it shows the DAG id being checked.

Testing Instructions

  1. Spin up the catalog and API stack ov just c && ov just a
  2. Run the staging_<media>_data_refresh DAGs and observe the checks for the conflicting DAGs are in place.

Screenshot 2024-11-08 at 16-38-45 staging_image_data_refresh - Grid - Airflow

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner November 8, 2024 20:54
@krysal krysal requested review from obulat and removed request for a team November 8, 2024 20:54
@openverse-bot openverse-bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 8, 2024
@krysal krysal merged commit 0fe2eb4 into main Nov 12, 2024
67 of 71 checks passed
@krysal krysal deleted the fix/staging_dags_concurrency branch November 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

Staging database restore can run concurrently with staging data refresh
3 participants