Change text to secondary on content-heavy pages

[dhruvkb]

Fixes

Fixes #5119 by @obulat
Fixes #5151 by @fcoveram

Description

This PR changes the content pages to use text-secondary for the body text, while retaining text-default for the headings.

Testing Instructions

Visit the content pages and see that the text should be a little lighter and less contrasted with the background.

I'll update the snapshots once @fcoveram approves the new designs.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[github-actions]

Latest k6 run output¹

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  8.6 MB/s
     data_sent......................: 838 kB  4.9 kB/s
     http_req_blocked...............: avg=26.97µs  min=1.92µs  med=3.92µs   max=11.91ms p(90)=5.64µs   p(95)=6.12µs  
     http_req_connecting............: avg=22.35µs  min=0s      med=0s       max=11.85ms p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=598.82ms min=55.28ms med=523.55ms max=2.44s   p(90)=1.08s    p(95)=1.18s   
       { expected_response:true }...: avg=598.82ms min=55.28ms med=523.55ms max=2.44s   p(90)=1.08s    p(95)=1.18s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=157.79µs min=43.13µs med=119.98µs max=14.68ms p(90)=188.73µs p(95)=221.24µs
     http_req_sending...............: avg=23.48µs  min=6.92µs  med=19.51µs  max=5.53ms  p(90)=25.6µs   p(95)=27.82µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=598.64ms min=55.13ms med=523.3ms  max=2.44s   p(90)=1.08s    p(95)=1.18s   
     http_reqs......................: 6400    37.045644/s
     iteration_duration.............: avg=3.2s     min=1.04s   med=2.63s    max=8.94s   p(90)=6.22s    p(95)=6.56s   
     iterations.....................: 1200    6.946058/s
     vus............................: 9       min=9       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

1. This comment will automatically update with new output each time k6 runs for this PR ↩

[fcoveram]

It looks great 🚀

[dhruvkb]

Thanks @fcoveram! I'll update the visual regression testing snapshots then.

[fcoveram]

I created this ticket requesting the update of text-secondary.

[dhruvkb]

@fcoveram changing the text-secondary color to gray-12 impacts the whole application, not just the text-heavy pages. Can you check out this branch and see if it looks good to you?

For example on this page the search query, artist name, duration, genre/category and license icons have all gotten darker.

[fcoveram]

Just for the record, during yesterday's community meeting, I agreed with @dhruvkb's idea to limit the use of a darker shade as text-secondary in text-heavy pages. So let's continue with that 👍