Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency django to v5 #5122

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Update dependency django to v5 #5122

merged 2 commits into from
Nov 13, 2024

Conversation

openverse-bot
Copy link
Collaborator

@openverse-bot openverse-bot commented Oct 31, 2024

This PR contains the following updates:

Package Type Update Change
django (changelog) project.dependencies major >=4.2.11, <5 -> >=5.1.3, <6

Release Notes

django/django (django)

v5.1.3

Compare Source

v5.1.2

Compare Source

v5.1.1

Compare Source

v5.1

Compare Source

v5.0.9

Compare Source

v5.0.8

Compare Source

v5.0.7

Compare Source

v5.0.6

Compare Source

v5.0.5

Compare Source

v5.0.4

Compare Source

v5.0.3

Compare Source

v5.0.2

Compare Source

v5.0.1

Compare Source

v5.0

Compare Source

v4.2.16

Compare Source

v4.2.15

Compare Source

v4.2.14

Compare Source

v4.2.13

Compare Source

v4.2.12

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot added the dependencies Pull requests that update a dependency file label Oct 31, 2024
@openverse-bot openverse-bot requested a review from a team as a code owner October 31, 2024 10:40
@openverse-bot openverse-bot added 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Oct 31, 2024
@openverse-bot openverse-bot requested review from dhruvkb and stacimc and removed request for a team October 31, 2024 10:40
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 31, 2024
@krysal
Copy link
Member

krysal commented Oct 31, 2024

This will address the start of #4015.

@openverse-bot openverse-bot force-pushed the gha-renovatedjango-5.x branch 2 times, most recently from f632432 to 4b53d6f Compare November 5, 2024 05:37
@openverse-bot
Copy link
Collaborator Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: api/pdm.lock
Command failed: pdm update --no-sync --update-eager django
WARNING: Project requires a python version of ==3.12.*, The virtualenv is being created for you as it cannot be matched to the right version.
INFO: python.use_venv is on, creating a virtualenv for this project...
Virtualenv is created successfully at /tmp/renovate/repos/github/WordPress/openverse/api/.venv
[FileNotFoundError]: [Errno 2] No such file or directory: '/home/ubuntu/.local/state'
WARNING: Add '-v' to see the detailed traceback

@openverse-bot
Copy link
Collaborator Author

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@dhruvkb
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 8 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@openverse-bot, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@dhruvkb dhruvkb requested review from krysal and removed request for stacimc November 13, 2024 08:59
@openverse-bot
Copy link
Collaborator Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks are passing, so it seems good to merge now. Wonder why I had to manually lock the PR and Renovate wasn't doing that part on its own 🤷‍♂️.

@krysal
Copy link
Member

krysal commented Nov 13, 2024

I tested a few searches on the main routes, and they seem fine. I'd like to explore what is improving here, but I don't think I'll have the time this week. There's no need to stop for that either. Feel free to go ahead if you want to, @dhruvkb.

@dhruvkb
Copy link
Member

dhruvkb commented Nov 13, 2024

I'll go ahead and merge it. I went through the release notes and did not find any breaking change or deprecation that will affect us.

@dhruvkb dhruvkb merged commit 6401439 into main Nov 13, 2024
50 checks passed
@dhruvkb dhruvkb deleted the gha-renovatedjango-5.x branch November 13, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐍 tech: python Involves Python
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

3 participants