Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #4911 by @zackkrida
Description
Fixes the extra white halo around the focus ring in
VSelectField
(used by the theme switcher and the language switcher).This was caused by the browser's default styles: they add an outline by default when a
select
element is focused. We remove some of the default styles, but the outline style is still set toauto
, and that adds a visible white outline in Chrome (but not in Firefox).Chrome screenshot
Firefox screenshot
We cannot use Tailwind's
outline-none
class here to remove the outline because it does not actually remove the outline, it adds the following styles instead:That's why I added a new utility class,
outline-style-none
here.Testing Instructions
Run the app and use the keyboard to navigate to the theme or language switcher in the footer. You should only see the pink/yellow border, and not a white outline around them.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin