Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VSelectField focus ring #4939

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix VSelectField focus ring #4939

merged 1 commit into from
Sep 17, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 17, 2024

Fixes

Related to #4911 by @zackkrida

Description

Fixes the extra white halo around the focus ring in VSelectField (used by the theme switcher and the language switcher).

This was caused by the browser's default styles: they add an outline by default when a select element is focused. We remove some of the default styles, but the outline style is still set to auto, and that adds a visible white outline in Chrome (but not in Firefox).

Chrome screenshot

Screenshot 2024-09-17 at 7 22 25 AM

Firefox screenshot

Screenshot 2024-09-17 at 7 22 46 AM

We cannot use Tailwind's outline-none class here to remove the outline because it does not actually remove the outline, it adds the following styles instead:

outline: 2px solid transparent;
outline-offset: 2px;

That's why I added a new utility class, outline-style-none here.

Testing Instructions

Run the app and use the keyboard to navigate to the theme or language switcher in the footer. You should only see the pink/yellow border, and not a white outline around them.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 17, 2024 07:05
@obulat obulat added 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon labels Sep 17, 2024
@openverse-bot openverse-bot added the 🧱 stack: documentation Related to Sphinx documentation label Sep 17, 2024
@obulat obulat mentioned this pull request Sep 17, 2024
8 tasks
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/4939

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obulat obulat merged commit dce6089 into main Sep 17, 2024
76 checks passed
@obulat obulat deleted the fix/select-focus-ring branch September 17, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants