Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 90% ES CPU alarms to those disabled for the data refresh #4858

Conversation

coson-lu
Copy link
Contributor

@coson-lu coson-lu commented Sep 4, 2024

…freshed (Issue #4826)

Fixes

Fixes #4826 by @AetherUnbound

Description

This pull requests adds the Elasticsearch 90% CPU alarm to the list of alarms which get disabled for the refresh data.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@coson-lu coson-lu requested a review from a team as a code owner September 4, 2024 04:54
@coson-lu coson-lu requested review from AetherUnbound and stacimc and removed request for a team September 4, 2024 04:54
@openverse-bot openverse-bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Sep 4, 2024
Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @coson-lu!

@AetherUnbound AetherUnbound changed the title Added 90% ES CPU alarms to the list of those disabled for the data re… Added 90% ES CPU alarms to those disabled for the data refresh Sep 4, 2024
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change which I'll make in-line, just didn't want this to get merged first

catalog/dags/common/cloudwatch.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks for the contribution @coson-lu!

@AetherUnbound AetherUnbound merged commit 09b25f9 into WordPress:main Sep 4, 2024
43 checks passed
@sarayourfriend
Copy link
Collaborator

Just a heads-up @AetherUnbound and any other spectators of this issue: modifying alarm states from DAGs requires IAM changes to give the Airflow execution environment permissions to do so. I've gone ahead and fixed it for this alarm, but keep that in mind when interacting with AWS resources in the future. Access is enabled and controlled via IAM and permissions errors will happen in the live environment without those additional changes.

@AetherUnbound
Copy link
Collaborator

Ahh, that was a complete oversight on my part. Thanks for the notice 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add 90% ES CPU alarms to the list of those disabled for the data refresh
5 participants