-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 90% ES CPU alarms to those disabled for the data refresh #4858
Added 90% ES CPU alarms to those disabled for the data refresh #4858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @coson-lu!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change which I'll make in-line, just didn't want this to get merged first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks for the contribution @coson-lu!
Just a heads-up @AetherUnbound and any other spectators of this issue: modifying alarm states from DAGs requires IAM changes to give the Airflow execution environment permissions to do so. I've gone ahead and fixed it for this alarm, but keep that in mind when interacting with AWS resources in the future. Access is enabled and controlled via IAM and permissions errors will happen in the live environment without those additional changes. |
Ahh, that was a complete oversight on my part. Thanks for the notice 🙂 |
…freshed (Issue #4826)
Fixes
Fixes #4826 by @AetherUnbound
Description
This pull requests adds the Elasticsearch 90% CPU alarm to the list of alarms which get disabled for the refresh data.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin