Update the recent search disclaimer

[obulat]

Fixes

Fixes #4741 by @sarayourfriend

Description

This PR updates the text of the recent searches privacy disclaimer.

The current sentence feels unfinished to me, though. Would adding "with anyone" make it clearer, @WordPress/openverse-maintainers?
"Recent searches are saved on your device and are not shared with anyone"

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

I think "with anyone" is implied by "never shared", and it doesn't read awkwardly to me, but I'm not a copy editor, so maybe it does not scan correctly to end without specifying the object of the sharing.

Regardless of the text we end up with, I would urge brevity as much as possible, and if we feel the need to clarify anything, we can turn the text into a link to the privacy page.

"with anyone" might also be technically incorrect. We do send recent individual searches to Plausible who store it in plain text, and they could show up in Sentry. They also show up in our API request logs and potentially our frontend request logs, depending on the type of interaction. With that line of thinking, even "never shared" is wrong (regardless of whether we specifically mean "never shared in a way that could identify you individually"). Maybe it would be better to just have "Recent searches are stored only on your device", and then make the text a link to the privacy page where we (should) have clear indications about what data is/is not stored, why, and the principles we're working from (privacy respecting, anonymous data, etc).

[fcoveram]

"Recent searches are stored only on your device", and then make the text a link to the privacy page where we (should) have clear indications about what data is/is not stored, why, and the principles we're working from (privacy respecting, anonymous data, etc).

This sounds great to me. I agree with keeping the sentence short.

[sarayourfriend]

LGTM!