Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Elasticsearch throttling on Ingestion Server #4683

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Jul 31, 2024

Fixes

Fixes #3977 by @krysal

Description

We haven't need to throttle ES for a while. We could do a live test deploying this immediately and start a data refresh before the scheduled for next week.

Testing Instructions

Run a data refresh and confirms it continues to work properly.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [n/a] I added or updated tests for the changes I made (if applicable).
  • [n/a] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [n/a] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Jul 31, 2024
@krysal krysal marked this pull request as ready for review July 31, 2024 21:13
@krysal krysal requested a review from a team as a code owner July 31, 2024 21:13
@krysal krysal requested review from obulat and stacimc and removed request for a team July 31, 2024 21:13
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, but I do wonder if this is something we need to change right now. We'll be removing the ingestion server eventually, so I'm hesitant to make changes to it that could be deferred until after that time. Plus, it might be easier to test this once everything is on Airflow! Just a thought though, we'll have to do an ingestion server deployment this week anyway because of #4667 🙂

@krysal
Copy link
Member Author

krysal commented Aug 1, 2024

@AetherUnbound The data refresh operated without a limit before the issue introduced by the filtered index addition (which is already solved), so we won't make brand changes anyway, no much to test here I think. I wanted to make it since we'll deploy the ingestion server again (maybe the last one!).

@krysal krysal merged commit ee78bdd into main Aug 1, 2024
49 checks passed
@krysal krysal deleted the drop/es_throttling branch August 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: ingestion server Related to the ingestion/data refresh server
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider droping off throttling in Ingestion Server filtered index creation
3 participants