Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate utilities/provider_tallies to PDM #4624

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jul 17, 2024

Fixes

Related to #4166 by @dhruvkb

Description

This PR migrates utilities/provider_tallies to PDM.

Testing Instructions

Run these instructions:
cd utilities/provider_tallies
../../ov pdm install
../../ov pdm run provider_tally_stats.py
You should see an error that you cannot connect to Redis printed in the terminal

If you start Redis locally or connect to the staging Redis cluster, and pass the correct port to the script:
../../ov pdm run provider_tally_stats.py --port=<DEV_REDIS_PORT>
you should see the output of the script in your terminal.
There are some warnings in the output, but that is not related to these changes.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner July 17, 2024 08:30
@obulat obulat mentioned this pull request Jul 17, 2024
8 tasks
@openverse-bot openverse-bot added 🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 17, 2024
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 17, 2024
@obulat obulat self-assigned this Jul 17, 2024
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some suggestions but they seem small enough to not warrant blocking the complete move away from Pipenv to PDM.

utilities/provider_tallies/pyproject.toml Outdated Show resolved Hide resolved
utilities/provider_tallies/pyproject.toml Outdated Show resolved Hide resolved
@@ -51,7 +51,7 @@ def _format_name(value: str) -> str:
type=str,
)
def main(output: Path, start_date: str | None):
redis = Redis("localhost", decode_responses=True, db=TALLY_DATABASE)
redis = Redis("localhost", port=6399, decode_responses=True, db=TALLY_DATABASE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments about this from #4623 apply here too 😕.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the pdm/utilities/provider_tallies branch from f8ec396 to 42430c4 Compare July 18, 2024 10:59
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No blocking changes but one suggestion for ov usage.

utilities/provider_tallies/README.md Outdated Show resolved Hide resolved
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
@obulat
Copy link
Contributor Author

obulat commented Jul 19, 2024

LGTM! No blocking changes but one suggestion for ov usage.

Awesome, thanks!

@obulat obulat merged commit 2423c2e into main Jul 19, 2024
41 checks passed
@obulat obulat deleted the pdm/utilities/provider_tallies branch July 19, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants