-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy changes implementation plan to avoid table rename #3568
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/3568 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. Changed files 🔄: |
...rust_and_safety/content_report_moderation/20230517-implementation_plan_mature_copy_change.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just asking to also drop changes to the report status in favour of dropping it entirely in #3494
- `AbstractMatureMedia` -> `AbstractSensitiveMedia` | ||
- `MatureImage` -> `SensitiveImage` | ||
- `MatureAudio` -> `SensitiveAudio` | ||
2. Add `sensitive` and `sensitive_filtered` as a new status and reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can actually skip the changes to report status as well, we just need to update reason
. #3494 removes the report status altogether in favour of a new moderation decision table that records the action taken from one or many reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that's great to hear! With that change, the new plan becomes way simpler 😄
...rust_and_safety/content_report_moderation/20230517-implementation_plan_mature_copy_change.md
Outdated
Show resolved
Hide resolved
...rust_and_safety/content_report_moderation/20230517-implementation_plan_mature_copy_change.md
Outdated
Show resolved
Hide resolved
6d9865f
to
670ffdb
Compare
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @obulat Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @AetherUnbound, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related to #2626 and follow up to #2126.
This PR updates the implementation plan for the
mature
->sensitive
code changes on the API to avoid a table rename. The maintainers decided that the table rename would be too much effort for too little gain, so this outlines the new set of steps necessary to make the code and copy changes for the API.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin