Update banner to match new designs and add analytics notification #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into banner-style-refresh
dhruvkb
added
🟧 priority: high
github-actions
bot
added
the
🧱 stack: documentation
|
Size Change: +1.59 kB (0%) Total Size: 846 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/2132 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
github-actions
bot
added
the
🧱 stack: mgmt
dhruvkb
force-pushed
the
new_banner_designs
branch
from
66351b4
to
5db7990
Compare
dhruvkb
removed
🧱 stack: mgmt
github-actions
bot
added
the
🧱 stack: documentation
|
Drafted and blocked awaiting the right icons and exact colors. |
…w_banner_designs
|
@sarayourfriend requesting your review here as I don't think @fcoveram has the capacity to look at this PR this week. |
|
I'll review this today or tomorrow. |
sarayourfriend
approved these changes
May 24, 2023
There was a problem hiding this comment.
LGTM, works and looks great locally and on my relatively low-spec Android phone.
We should keep in mind the banner stacking and probably consider avoiding adding any more... Even two feels like a lot and will now be a common occurrence for folks visiting certain translations. At least the case with three is impossible to reach organically, right? CC search doesn't redirect any of our language prefixes as far as I can tell in my brief testing.
|
@sarayourfriend you're right, while 3 is the theoretical maximum, 2 is the most that will occur in practice. CC Search does not redirect to our localised pages. Even then, we need to be conscious about adding any more banners in the future, or finding an alternative UI to display notifications (other than banners) if there is a need to add any new ones. |
|
Thanks for the work @dhruvkb, and @sarayourfriend and @zackkrida for reviewing it.
+100. To this point, the best approach is to include notifications and any other similar feedback during the search experience or in context, like in the playing audio message when focusing on the component. We should avoid thinking of "adding a banner" as a first solution each time we need to convey information. That degrades UX and product quality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #823 by @dhruvkb
Description
This PR
VNotificationBannercomponent to supportTesting Instructions
You can directly refer to updated snapshots in the "Files changed" tab. Or you can do the following:
http://localhost:8443/hi/?referrer=creativecommons.orghttp://localhost:8443/hi/about/?referrer=creativecommons.orgChecklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin