Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish changelog for catalog-2023.04.27.02.43.13 #1914

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

openverse-bot
Copy link
Collaborator

This changelog PR was automatically generated for @stacimc as a result of the Release app workflow.

@openverse-bot openverse-bot requested a review from a team as a code owner April 27, 2023 02:51
@openverse-bot openverse-bot added skip-changelog 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Apr 27, 2023
@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/1914

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Comment on lines 1 to 5
# 2023.04.27.02.43.13

## Improvements

- Add `LABEL` to link repo with GHCR image (#1223) @dhruvkb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, that indentation seems off 😰

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to pass the substrings to dedent:

dedent(
f"""
# {tag_date}
{release_body}
"""
)

Maybe something about pulling it from the release draft text has them indented strangely?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed ff73f21 to fix for this file and made a change to the write script to hopefully prevent it in the future. Also opened #1916 to help avoid problems like these.

@obulat obulat merged commit cfc9e98 into main Apr 27, 2023
@obulat obulat deleted the changelog/catalog-2023.04.27.02.43.13 branch April 27, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed skip-changelog 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants