Skip to content

RTL-ify the translation notification banner border #572

Closed

Description

Description

The notification banner for translations with less than a certain percentage of translated strings has a leading-edge border of a different color, however this is set specifically to the left edge and therefore does not switch to the correct leading edge for RTL languages. This was fine before WordPress/openverse-frontend#1184 because the banners were always dir="ltr" but after that PR the banner does follow the document direction generally.

Reproduction

  1. Visit https://search-staging.openverse.engineering/ar and note that the layout is RTL except for the leading edge border.

Screenshots

You can see this in the snapshot tests here: https://github.com/WordPress/openverse-frontend/blob/af82534ee8f43b603d3fd009aa48dcf6c1b3618e/test/playwright/visual-regression/sources.spec.ts-snapshots/sources-rtl-lg-linux.png

Additional context

Realized this while reviewing WordPress/openverse-frontend#1257.

Resolution

  • 🙋 I would be interested in resolving this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    • Status

      ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions