Open
Description
openedon Sep 26, 2024
Problem
Most of the colors are determined using CSS-only methods. However, the VWordPressLink
uses JS to set the color. This was first done because the logo is used on a background that is different from the main background color in the mobile pages modal (its background is always black, both in the dark and the light themes).
Description
Refactor the WP logo component to use the CSS-only methods of color scheme detection. The mobile nav should add a CSS variable (or change the color mode class name) to enable setting the correct color to the logo component.
Alternatives
Leave the JS method. It will be confusing long term to have the JS-based pattern still present in the app, for anyone trying to understand how to correctly style components.
Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Type
Projects
Status
🏗 In Progress