Skip to content

Remove handling for Hit in API code #4033

Open

Description

Problem

Earlier our serializers were written in a way to support Hit as well as subclasses of AbstractMedia depending on whether they were serializing results from the ES or the API database respectively.

Later we decided to

  • slim down the ES indices
  • make 1 call to the API DB per request to map Hits to models
  • always serialize models, never Hits

These changes did not remove all edge-case handling that were incorporated into the API for fields that were not present in Hits.

Occurrences

Collect occurrences of such handling here. The issue can be considered resolved when all of these occurrences are resolved.

// 🚧 TODO

Additional context

An example of this handling being removed is #4027.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    • Status

      📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions