Skip to content

Improve invalid source parameter handling #4030

Closed

Description

Problem

See #3895 (reply in thread) for background of this discussion.

Description

We'll make the following changes:

  • Remove the warning logging when invalid sources are encountered.
  • Add a warnings list to the search response when a partially invalid source list is passed.
  • Raise a validation error when all sources passed are invalid, when not a single valid source is passed (e.g., all the sources are mispelled or disabled)

Alternatives

Additional context

Marking high priority for the logging improvements, because we don't need to fill our logging with these messages now that we have the answer we wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

✨ goal: improvementImprovement to an existing user-facing feature🕹 aspect: interfaceConcerns end-users' experience with the software🟧 priority: highStalls work on the project or its dependents🧱 stack: apiRelated to the Django API

Type

No type

Projects

  • Status

    ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions