Skip to content

Update the SMK (statensmuseum) provider script #1673

Closed

Description

The provider script for SMK does some manual building of image urls:

https://github.com/WordPress/openverse-catalog/blob/b07282dc00ab583a6096e6749f923d34767bd7cc/openverse_catalog/dags/providers/provider_api_scripts/staten_museum.py#L158-L160

These image URLs timeout or take a very long time to download, which has prevented us from making SMK live in Openverse.

Todos

  • Rename script to SMK for clarity (can also refer to them as the National Gallery of Denmark in comments somewhere, also for clarity)
  • Update the 'full' url to something more reasonable, like a 2000px wide thumbnail (since we refer users to the original source for downloading anyway, we shouldn't need the 'true' full URL. We might want it if we ever do support full downloads, but this should be a separate discussion.
  • Use any new API fields or metadata available to update the script

Here is an example results endpoint: https://api.smk.dk/api/v1/art/?object_number=kms1&lang=en

Note that there's a image_hq boolean field to indicate how big an image is, along with an image_size field that gives the exact size, which could be factored into this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Type

No type

Projects

  • Status

    ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions