Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup centralisation of branch protection rules for all repos #136

Closed
1 task
dhruvkb opened this issue Jan 6, 2022 · 2 comments
Closed
1 task

Setup centralisation of branch protection rules for all repos #136

dhruvkb opened this issue Jan 6, 2022 · 2 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Jan 6, 2022

Problem

All repositories are currently managing their own branch protection rules. Based on needs such as pushing to GH pages or allowing force-push to one's one branches but not master can cause these rules to diverge from each other as well as from the ideal configuration.

Description

These rules should be defined in this repository and synced to all downstream repositories so that we have a consistent set of rules everywhere.

Additional context

This sort of work has been done earlier. Refer to this implementation by CC for example.

Implementation

  • 🙋 I would be interested in implementing this feature.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Jan 6, 2022
@sarayourfriend
Copy link
Contributor

This would be mostly unnecessary with #336, at least in the longer term.

It is also a duplicate of an infrastructure issue we have to move all branch protection rules into Terraform. I'd prefer if we had the rules in Terraform, even if it's only for a single repository, mostly so that the changes are reviewed as appropriate. If the monorepo RFC goes through, @dhruvkb should we close this issue?

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 6, 2022

We should close this as a duplicate of https://github.com/WordPress/openverse-infrastructure/issues/173. The monorepo will eventually merge everything but for now it excludes the infra and catalog repos so this feature will still be useful.

@dhruvkb dhruvkb added the ⛔️ status: discarded Will not be worked on label Dec 6, 2022
@dhruvkb dhruvkb closed this as completed Dec 6, 2022
@dhruvkb dhruvkb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
dhruvkb pushed a commit that referenced this issue Feb 20, 2023
Remove unnecessary call to clean audio data ingestion server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants