Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test issue to check the CI #1055

Closed
obulat opened this issue Mar 28, 2023 · 1 comment
Closed

Test issue to check the CI #1055

obulat opened this issue Mar 28, 2023 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API

Comments

@obulat
Copy link
Contributor

obulat commented Mar 28, 2023

Description

Reproduction

  4. See error.

Screenshots

Environment

  • Device:
  • OS:
  • Browser:
  • Version:
  • Other info:

Additional context
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Mar 28, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@rsubra13 @AetherUnbound
Do not show a load completion message if all steps failed (#1055)
bbb8d97 
* Replace unneeded comprehension with generator

`any` allows us to pass in a generator rather than a collection.
Doing so removes a pair of brackets, making the intent slightly clearer.
It will also have lazy evaluation advantages as the whole list is not generated.

* Use f'' strings

* Merge isinstance calls for better readability

* Added `skip_report_completion` function to determine whether to skip slack notications

* Fixed test failures by fixing datatypes

* Reorder tests for clarity

* Add check for condition where all record counts by media type are None

* Lint

---------

Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
@sarayourfriend
Copy link
Contributor

Closing this issue. Hopefully we've tested all we needed to in the last year 😀

@sarayourfriend sarayourfriend closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obulat @sarayourfriend