This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Use aria-label for WordPress affiliation link #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2187 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟨 priority: medium
|
Size Change: -8 B (0%) Total Size: 908 kB ℹ️ View Unchanged
|
dhruvkb
approved these changes
Feb 15, 2023
| @@ -10,8 +13,7 @@ | |||
| class="label-regular flex flex-row items-center gap-1" | |||
| > | |||
| <template #wordpress> | |||
| <WordPress class="aria-hidden" /> | |||
There was a problem hiding this comment.
class="aria-hidden"? I think just making this bit aria-hidden=true would've fixed it.
There was a problem hiding this comment.
Do you mean removing aria-label added in this PR and adding the non-tailwind aria-hidden class would fix the "no space between WordPress and project for screenreaders" problem, @dhruvkb?
I tried with VoiceOver, and when you and aria-label to the link, all of the other content becomes invisible for screenreader.
There was a problem hiding this comment.
Huh, that's interesting. I approved your solution though because it definitely works.
zackkrida
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2183 by @obulat
Description
This PR adds an
aria-labelto the WordPress link in the footer to make sure that the screen readers read it correctly, with the necessary pauses between the words.Testing Instructions
Turn on a screenreader and listen to what it says for the link in the footer.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin