Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add a PR template to the repository #110

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Add a PR template to the repository #110

merged 1 commit into from
Aug 3, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 2, 2021

Targets WordPress/openverse#35

This PR adds a PR template to the repository.

@dhruvkb dhruvkb requested a review from a team as a code owner August 2, 2021 16:50
zackkrida
zackkrida approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @krysal that I don't think we need the "or delete this section entirely." language (on any of the comments IMO) but this is great!

@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 3, 2021

Those comments are generally to help people without prior experience with contribution. We came across lots of people at CC who didn't know what to put in PR descriptions.

@dhruvkb dhruvkb merged commit 466c36e into main Aug 3, 2021
@dhruvkb dhruvkb deleted the pr_template branch August 3, 2021 00:40
@zackkrida zackkrida added 📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obulat obulat obulat approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvkb @zackkrida @obulat