This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Audio waveform progress bar extends beyond the end of the waveform body #692
Closed
Description
Description
When playing an audio file all the way through to the end, the progress bar will extend beyond the end of the waveform body.
I'm not sure what causes this, but it seeems like it would just be a small math issue or more likely we're ignoring something critical when pulling the waveform dimensions from clientWidth
.
Reproduction
- Run main and go to an audio search that includes a short file (it's easiest and most prominent on short files) like http://localhost:8443/audio/5365bca5-7bd8-4344-b8e4-dad1cf219456
- Play the audio file through to the end
- Note the progress bar, timestamp, and focus bar (when focused) extending beyond the end of the waveform body.
Expectation
The progress bar should end exactly at the end of the waveform body.
Screenshots
- 🙋 I would be interested in resolving this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment