Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Replace deprecated set-output command #910

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Replace deprecated set-output command #910

merged 1 commit into from
Dec 7, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Dec 5, 2022

Fixes

Fixes WordPress/openverse#1327 by @krysal

Description

The PR replaces the command by writing to the environment file as suggested by GitHub.

Testing Instructions

Wait to see if the ci_cd.yml workflow passess.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner December 5, 2022 20:55
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Dec 5, 2022
@krysal krysal force-pushed the change_to_env_file branch 5 times, most recently from 253ec8d to 148c37a Compare December 5, 2022 21:44
@krysal
Copy link
Member Author

krysal commented Dec 5, 2022

Does anyone see the origin of the error thrown by actionlint? I don't get it locally.

.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right; thanks!

@krysal krysal requested a review from dhruvkb December 6, 2022 17:07
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have added similar changes to the frontend, but I used Python: https://github.com/WordPress/openverse-frontend/pull/1940/files

@krysal krysal merged commit 4b8f4e0 into main Dec 7, 2022
@krysal krysal deleted the change_to_env_file branch December 7, 2022 13:47
@krysal krysal added 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed ✨ goal: improvement Improvement to an existing user-facing feature labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command
5 participants