Use the default provider categories during ingestion

[obulat]

Fixes

Fixes WordPress/openverse#1683 by @dhruvkb

Description

This PR adds a default category to media items in the MediaStore's clean_media_metadata method.
With this change, this is how category for an item is determined:

• if a provider script can assign different categories, it should set the item category in the get_record_data method (or when calling add_item with old scripts).
• MediaStore uses the category value a provider script passes.
• If the category is None, MediaStore tries to add the category that is default for provider, and is listed in provider_details.py module.

Testing Instructions

Run one of the data collection DAGs until you see Wrote 100 lines to the disc in the Pull data task log. Stop the DAG. Wait a couple of seconds until the DAG finishes, and then check the data in the database (I use DataGrip connected to the localhost's DB). The category column should be filled. For example, for "clevelandmuseum", category should be set to digitized_artwork, and for "sciencemuseum", it should be set to photograph.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[AetherUnbound]

Looks straightforward! Just one question.

[AetherUnbound]

Looks great!

[zackkrida]

Did you mention why this is being removed? As I understand Flickr is exclusively photos (and some videos) and not illustrations or other media types.

[obulat]

Flickr returns one of 3 type values, and we set the category as photograph only to the photos, not screenshots or other:

def _get_category(image_data):
    """
    Flickr has three types:
        0 for photos
        1 for screenshots
        3 for other
    Treating everything different from photos as unknown.
    """
    if "content_type" in image_data and image_data["content_type"] == "0":
        return ImageCategory.PHOTOGRAPH.value
    return None

So, even before this PR, Flickr script was using photograph as the category for type 0. I don't know if we should investigate what types 1 and 3 are, and whether we can use them for categorizing as well.

[zackkrida]

Nit: I think I personally prefer the full provider here instead of prov because it's clearer, but it doesn't matter much.

[obulat]

I like the full provider here, but it's prov in all of the provider scripts, so I just used this for consistency (so that I don't have to change what I copy-pasted :) ) Do you think we should open an issue to replace provider with prov, @zackkrida?

[AetherUnbound]

+1 to using the full name rather than an alias 😄 I think an issue for that would be excellent! It'd be a solid "good first issue" as well

[zackkrida]

LGTM! Some small nits (take them or leave them) but otherwise looks great. Successfully saw the digitized_artwork category on my 6k Cleveland Museum local DAG run.