This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes WordPress/openverse#1721 by @zackkrida
Description
This adds a simple DAG that takes 2 minutes to run. It is always run manually via the UI. Basically it is meant as an integration test.
I'm not sure if anything more needs to be added to this for it to be an effective test. I'll let @zackkrida and others let me know about that.
@krysal suggested that we move it into another folder, but I'm not sure where to move it. Do we need a separate folder for these type of "test/healthcheck" DAGs? If we only have one it doesn't seem worth it to me but if we're going to have more of these types of DAGs then it's probably a good idea to separate them.
Tests
Checkout this branch and run the
healthcheck
DAG via the UI. Be sure to to toggle the DAG to "active" state before running it (TIL!)I didn't add unit tests for this because, well, I wasn't sure what I would test. The
main
function takes two minutes to run so adding a unit test for it seems like a bad idea.Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin