Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Add manually run healthcheck DAG #151

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Add manually run healthcheck DAG #151

merged 1 commit into from
Aug 27, 2021

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Aug 23, 2021

Fixes

Fixes WordPress/openverse#1721 by @zackkrida

Description

This adds a simple DAG that takes 2 minutes to run. It is always run manually via the UI. Basically it is meant as an integration test.

I'm not sure if anything more needs to be added to this for it to be an effective test. I'll let @zackkrida and others let me know about that.

@krysal suggested that we move it into another folder, but I'm not sure where to move it. Do we need a separate folder for these type of "test/healthcheck" DAGs? If we only have one it doesn't seem worth it to me but if we're going to have more of these types of DAGs then it's probably a good idea to separate them.

Tests

Checkout this branch and run the healthcheck DAG via the UI. Be sure to to toggle the DAG to "active" state before running it (TIL!)

I didn't add unit tests for this because, well, I wasn't sure what I would test. The main function takes two minutes to run so adding a unit test for it seems like a bad idea.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend marked this pull request as ready for review August 23, 2021 21:15
@sarayourfriend sarayourfriend requested a review from a team as a code owner August 23, 2021 21:15
@zackkrida
Copy link
Member

Noting some things I'll want to consider when I review this:

  • non provider DAGs, like the Log cleanup DAG #139 — where should we keep 'em?
  • settings that seem hardcoded to assume DAGs are for image providers:
    • _DEFAULT_PROVIDER vars
    • static pull_image_data task_id in get_main_runner_operator
  • integration test suite in airflow? sounds awesome to me, is it a good/bad/common/uncommon practice?

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. My thought would be, LGTM, and then I will create a new ticket for the other considerations listed above.

@obulat
Copy link
Contributor

obulat commented Aug 26, 2021

LGTM!

@sarayourfriend sarayourfriend merged commit 608fa9e into main Aug 27, 2021
@sarayourfriend sarayourfriend deleted the add/simulated-dag branch August 27, 2021 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add low-complexity testing DAG
3 participants