TinyMCE: Clean TinyMCE internal DOM state on blur#8879
Closed
Conversation
aduth
added
[Type] Bug
This was referenced Aug 11, 2018
Closed
Member
Author
4 tasks
Member
|
Closing this PR as #8877 is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8877
In Progress: Still needs unit tests, documentation, and evaluation of whether this is the best approach. Other options include calling
setContentfromRichTextto just replace the content, though this may be more intensive since it requires TinyMCE to re-parse. There may be room for improvement to refactor shared behaviors between "dom" and "content" formats informats.js. Also not sure we want to expose this as a proper format for RichText.This pull request seeks to resolve an issue where lingering TinyMCE DOM state when a RichText field is blurred can occasionally cause forced re-focuses.
Testing instructions:
Repeat steps to reproduce from #8877, verifying that caret placement occurs as expected.
Ensure end-to-end tests pass: