Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/Try: Make pullquote a variation #8821

Closed
wants to merge 2 commits into from
+23 −374
Closed

WIP/Try: Make pullquote a variation #8821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
495ccc8
WIP/Try: Make pullquote a variation
Aug 10, 2018
f76985c
Try simply removing the pullquote.
Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions block-library/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import * as list from '../packages/block-library/src/list';
import * as more from '../packages/block-library/src/more';
import * as nextpage from '../packages/block-library/src/nextpage';
import * as preformatted from '../packages/block-library/src/preformatted';
import * as pullquote from '../packages/block-library/src/pullquote';
import * as reusableBlock from '../packages/block-library/src/block';
import * as separator from '../packages/block-library/src/separator';
import * as shortcode from '../packages/block-library/src/shortcode';
Expand Down Expand Up @@ -83,7 +82,6 @@ export const registerCoreBlocks = () => {
more,
nextpage,
preformatted,
pullquote,
separator,
reusableBlock,
spacer,
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
@import "./more/editor.scss";
@import "./nextpage/editor.scss";
@import "./preformatted/editor.scss";
@import "./pullquote/editor.scss";
@import "./quote/editor.scss";
@import "./shortcode/editor.scss";
@import "./spacer/editor.scss";
Expand Down
2 changes: 0 additions & 2 deletions packages/block-library/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import * as list from './list';
import * as more from './more';
import * as nextpage from './nextpage';
import * as preformatted from './preformatted';
import * as pullquote from './pullquote';
import * as reusableBlock from './block';
import * as separator from './separator';
import * as shortcode from './shortcode';
Expand Down Expand Up @@ -71,7 +70,6 @@ export const registerCoreBlocks = () => {
more,
nextpage,
preformatted,
pullquote,
separator,
reusableBlock,
spacer,
Expand Down
32 changes: 0 additions & 32 deletions packages/block-library/src/pullquote/editor.scss
View file
Open in desktop

This file was deleted.

124 changes: 0 additions & 124 deletions packages/block-library/src/pullquote/index.js
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions packages/block-library/src/pullquote/style.scss
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions packages/block-library/src/pullquote/test/__snapshots__/index.js.snap
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions packages/block-library/src/pullquote/test/index.js
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions packages/block-library/src/pullquote/theme.scss
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/block-library/src/quote/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const settings = {
styles: [
{ name: 'default', label: __( 'Regular' ), isDefault: true },
{ name: 'large', label: __( 'Large' ) },
{ name: 'fancy', label: __( 'Fancy' ) },
],

transforms: {
Expand Down
21 changes: 21 additions & 0 deletions packages/block-library/src/quote/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,25 @@
text-align: right;
}
}

&.is-style-fancy {
padding: 3em 0;
text-align: center;
border-top: 4px solid $dark-gray-500;
border-bottom: 4px solid $dark-gray-500;
color: $dark-gray-600;

p {
font-size: 24px;
line-height: 1.6;
}

cite,
footer {
position: relative;
color: $dark-gray-600;
text-transform: uppercase;
font-size: $default-font-size;
}
}
}
2 changes: 1 addition & 1 deletion packages/block-library/src/quote/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
}

.wp-block-quote:not(.is-large):not(.is-style-large) {
.wp-block-quote:not(.is-large):not(.is-style-large):not(.is-style-fancy) {
border-left: 4px solid $black;
padding-left: 1em;
}
1 change: 0 additions & 1 deletion packages/block-library/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
@import "./latest-comments/style.scss";
@import "./latest-posts/style.scss";
@import "./paragraph/style.scss";
@import "./pullquote/style.scss";
@import "./quote/style.scss";
@import "./separator/style.scss";
@import "./subhead/style.scss";
Expand Down
2 changes: 0 additions & 2 deletions packages/block-library/src/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
@import "./code/theme.scss";
@import "./preformatted/theme.scss";
@import "./pullquote/theme.scss";
@import "./quote/theme.scss";
@import "./separator/theme.scss";
@import "./table/theme.scss";
@import "./video/theme.scss";
2 changes: 0 additions & 2 deletions packages/editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,8 +1353,6 @@ export function getSuggestedPostFormat( state ) {
case 'core/image':
return 'image';
case 'core/quote':
case 'core/pullquote':
return 'quote';
case 'core/gallery':
return 'gallery';
case 'core/video':
Expand Down
6 changes: 0 additions & 6 deletions phpunit/fixtures/long-content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ <h2>Media Rich</h2>
<!-- wp:paragraph -->
<p>You can build any block you like, static or dynamic, decorative or plain. Here&#x27;s a pullquote block:</p>
<!-- /wp:paragraph -->
<!-- wp:pullquote -->
<blockquote class="wp-block-pullquote">
<p>Code is Poetry</p>
<cite>The WordPress community</cite>
</blockquote>
<!-- /wp:pullquote -->
<!-- wp:paragraph {"align":"center"} -->
<p style="text-align:center"><em>If you want to learn more about how to build additional blocks, or if you are interested in helping with the project, head over to the <a href="https://github.com/WordPress/gutenberg">GitHub repository</a>.</em></p>
<!-- /wp:paragraph -->
Expand Down
4 changes: 0 additions & 4 deletions post-content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,6 @@
<p><?php _e( 'You can build any block you like, static or dynamic, decorative or plain. Here&#8217;s a pullquote block:', 'gutenberg' ); ?></p>
<!-- /wp:paragraph -->

<!-- wp:pullquote -->
<blockquote class="wp-block-pullquote"><p><?php _e( 'Code is Poetry', 'gutenberg' ); ?></p><cite><?php _e( 'The WordPress community', 'gutenberg' ); ?></cite></blockquote>
<!-- /wp:pullquote -->

<!-- wp:paragraph {"align":"center"} -->
<p style="text-align:center">
<em>
Expand Down
5 changes: 0 additions & 5 deletions test/integration/full-content/fixtures/core__pullquote.html
View file
Open in desktop

This file was deleted.

Loading