Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Editable state #847

Closed
wants to merge 1 commit into from
Closed

Experimental Editable state #847

wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

This is a WIP. See #771.

@ellatrix ellatrix force-pushed the try/editable-state-2 branch 3 times, most recently from 8a5bcd1 to f046ea8 Compare May 19, 2017 21:24
@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] In Progress Tracking issues with work in progress labels May 22, 2017
@ellatrix ellatrix mentioned this pull request May 24, 2017
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person, I feel like we will be able to make much better judgments about how the data structure will affect our coding and the editor if we have a playground in which to test it. We need to figure out which operations we care about (for example, insert a block at…, split at block at…, replace content at…with a new block, etc…)

Hopefully I will pull together some of my own exploration based on a Rope structure. Let's not be afraid to create Markdown files or code files with example API usage but no actual implementation. I'd rather doodle with code we'll never use than spend a lot of time building the wrong thing 😉

@ellatrix ellatrix added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jun 22, 2017
@ellatrix ellatrix mentioned this pull request Jul 3, 2017
@nylen nylen removed the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 3, 2017
@nylen
Copy link
Member

nylen commented Aug 3, 2017

I think we need to do this soon. We have a lot of complicated code around splitting and transforming block types that could be greatly simplified (and unit-tested) with a more appropriate state structure. For example #1674 and #2170 would both benefit from this.

@ellatrix
Copy link
Member Author

Closing the PR (there's still the ticket to discuss). Not sure if we'll eventually go for this approach (as opposed to HTML or tree state), and would need to be redone if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants