ToolsPanel: Migrate styles to an SCSS Module#80445
Conversation
|
Size Change: +823 B (+0.01%) Total Size: 7.73 MB 📦 View Changed
|
|
Flaky tests detected in 05e51c1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29653271225
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Follow up to #79443. See #66806.
What?
Migrates the complete
ToolsPanelstyling surface from Emotion to a shared SCSS Module and restores the header heading typography affected by theViewmigration.Why?
Viewnow forwards Emotion-generated classes without reserializing them. That exposed an insertion-order conflict betweenToolsPanel's heading styles andHeading's base typography.Moving the component's styles to an SCSS Module fixes the cascade at its source and removes the remaining ToolsPanel-owned Emotion styles.
How?
Gridprimitive with the equivalent two-column layout and spacing.classNamebehavior, DOM structure, prop/ref forwarding, selector specificity, and physical RTL margin behavior.clsxand removes the obsolete ESLint suppression.Testing Instructions
Storybook
Editor
Testing Instructions for Keyboard
In either smoke test, focus the options button, open it with Enter or Space, navigate the menu with the arrow keys, and dismiss it with Escape. Confirm focus remains visible and returns to the options button.
Screenshots or screencast
Emphasis on the heading regression, which is now fixed
Use of AI Tools
Codex was used to audit the complete ToolsPanel styling surface, implement the migration, add regression coverage, inspect the generated CSS, and run validation.