Suggest mode 5/7: inline suggestion operations#80431
Draft
adamsilverstein wants to merge 1 commit into
Draft
Conversation
Adds the suggestion-specific layer on top of the marker primitive: create, accept, and reject inline text (add/del) and formatting suggestions (operations.js); the pure reconcilers that turn a text edit or a format toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/ line delete-range resolution; strip-markers for clean attribute snapshots; findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook. Still pure modules - the keyboards and reconcilers that call them into the live editor land in the final step.
This was referenced Jul 17, 2026
|
Size Change: 0 B Total Size: 7.74 MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR
Adds the suggestion-specific layer on top of the marker primitive: create,
accept, and reject inline text (add/del) and formatting suggestions
(operations.js); the pure reconcilers that turn a text edit or a format
toggle into marker actions (reconcile-edit.js, reconcile-format.js); word/
line delete-range resolution; strip-markers for clean attribute snapshots;
findSuggestionText/findMarkerText helpers; and the annotate-suggestions hook.
Still pure modules - the keyboards and reconcilers that call them into the
live editor land in the final step.
Suggest mode stack
This rebuilds the manually-stacked Suggest mode work (#73411) as a GitHub Stack of 7 small, independently reviewable PRs. Each is CI-green on its own and builds on the one below it:
The whole feature can be exercised end-to-end via the combined testing branch #78994 (Playground). Behind the "Suggestion Mode" experiment (Gutenberg > Experiments).