Skip to content

Site Editor: Save hub button styling while saving #79287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanfra merged 4 commits into from
Jun 19, 2026
Merged

Site Editor: Save hub button styling while saving #79287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff3037b
Keep save hub button primary while saving.
juanfra Jun 17, 2026
c207c3d
Migrate experimental HStack to Stack
juanfra Jun 18, 2026
4c2c326
Merge branch 'trunk' into fix/save-hub-button-variant
juanfra Jun 18, 2026
eb6fe17
Update stack props and remove duplicate padding.
juanfra Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/edit-site/src/components/save-hub/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* WordPress dependencies
*/
import { useSelect } from '@wordpress/data';
import { __experimentalHStack as HStack } from '@wordpress/components';
import { Stack } from '@wordpress/ui';
import { store as coreStore } from '@wordpress/core-data';
import { check } from '@wordpress/icons';

Expand All @@ -28,15 +28,15 @@ export default function SaveHub() {
};
}, [] );
return (
<HStack className="edit-site-save-hub" alignment="right" spacing={ 4 }>
<Stack className="edit-site-save-hub" gap="lg">
<SaveButton
className="edit-site-save-hub__button"
variant={ isDisabled ? null : 'primary' }
variant={ isDisabled && ! isSaving ? null : 'primary' }
showTooltip={ false }
icon={ isDisabled && ! isSaving ? check : null }
showReviewMessage
__next40pxDefaultSize
/>
</HStack>
</Stack>
);
}
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/save-hub/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
border-top: 1px solid var(--wpds-color-stroke-surface-neutral);
flex-shrink: 0;
margin: 0;
padding: $grid-unit-20 $canvas-padding;
padding: $grid-unit-20;
}

.edit-site-save-hub__button {
Expand Down
5 changes: 0 additions & 5 deletions tools/eslint/suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,11 +895,6 @@
"count": 4
}
},
"packages/edit-site/src/components/save-hub/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/edit-site/src/components/sidebar-global-styles/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand Down
Loading