Skip to content

Fix type of $block_instance parameter in block_core_image_render_lightbox() #78790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 2 commits into from
May 29, 2026
Merged

Fix type of $block_instance parameter in block_core_image_render_lightbox() #78790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678c850
Fix type of $block_instance parameter in block_core_image_render_ligh…
westonruter May 28, 2026
b1310b0
Add native type hints for non-filtered params
westonruter May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/block-library/src/image/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,13 @@ function block_core_image_get_lightbox_settings( $block ) {
*
* @since 6.4.0
*
* @param string $block_content Rendered block content.
* @param array $block Block object.
* @param array $block_instance Block instance.
* @param string $block_content Rendered block content.
* @param array $block Block object.
* @param WP_Block $block_instance Block instance.
*
* @return string Filtered block content.
*/
function block_core_image_render_lightbox( $block_content, $block, $block_instance ) {
function block_core_image_render_lightbox( $block_content, array $block, WP_Block $block_instance ) {
/*
* If there's no IMG tag in the block then return the given block content
* as-is. There's nothing that this code can knowingly modify to add the
Expand Down
Loading