Skip to content

Menu: Fix flaky keyboard focus test #78162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 1 commit into from
May 11, 2026
Merged

Menu: Fix flaky keyboard focus test #78162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/src/menu/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ describe( 'Menu', () => {
// Menu closed
expect( screen.queryByRole( 'menuitem' ) ).not.toBeInTheDocument();

await press.Space();
// Keyboard-triggered clicks have `detail: 0`, which Ariakit uses to
// choose the initial item focus path instead of the pointer path.
await press.Space( toggleButton, { detail: 0 } );

// Menu open, focus is on the first focusable item
await waitForFocusedMenuItem( 'First item' );
Expand Down
Loading