Skip to content

Media editor modal: disable scroll wheel zoom while a pan/drag is active #77863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 1 commit into from
May 1, 2026
Merged

Media editor modal: disable scroll wheel zoom while a pan/drag is active #77863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/media-editor/src/image-editor/core/interaction-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@ export class InteractionController {
handleWheel( e: WheelEvent ): void {
e.preventDefault();

if ( this.drag ) {
return;
}

// Debounced gesture boundaries for wheel zoom.
// Start on first wheel event, end after 300ms of no events.
if ( ! this.wheelGestureActive ) {
Expand Down
25 changes: 25 additions & 0 deletions packages/media-editor/src/image-editor/core/test/interaction-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,31 @@ describe( 'InteractionController', () => {
expect( setZoomCall![ 0 ] ).toBe( 4 );
} );

it( 'does not zoom while pointer pan is active', () => {
const state = makeState( { zoom: 2 } );
const { controller } = createController( state );
const el = createMockElement();

controller.handlePointerDown(
createPointerEvent( { clientX: 100, clientY: 100 } ),
el
);

jest.clearAllMocks();

const wheelEvent = createWheelEvent( {
deltaY: -100,
currentTarget: null,
} );
controller.handleWheel( wheelEvent );

expect( wheelEvent.preventDefault ).toHaveBeenCalled();
expect( actionMocks.setZoom ).not.toHaveBeenCalled();
expect( actionMocks.setZoomAtPoint ).not.toHaveBeenCalled();

el._fire( 'pointerup', createPointerEvent() );
} );

it( 'calls onGestureStart on first wheel, onGestureEnd after debounce', () => {
jest.useFakeTimers( {
doNotFake: [ 'requestAnimationFrame', 'cancelAnimationFrame' ],
Expand Down
Loading