Skip to content

Fix: ensure Save Draft and Publish buttons are disabled during media upload#77622

Open
Ashok-A15 wants to merge 1 commit into
WordPress:trunkfrom
Ashok-A15:patch-2
Open

Fix: ensure Save Draft and Publish buttons are disabled during media upload#77622
Ashok-A15 wants to merge 1 commit into
WordPress:trunkfrom
Ashok-A15:patch-2

Conversation

@Ashok-A15

Copy link
Copy Markdown

Problem

The "Save Draft" and "Publish" buttons are not consistently disabled during media uploads, which can lead to flaky behavior in editor interactions and failing E2E tests.

Cause

The disabled state logic relied on a complex conditional that did not reliably reflect the post saving lock state (isPostSavingLocked), especially during media uploads.

Solution

Simplified the disabled state logic for both Save Draft and Publish buttons to ensure they are consistently disabled when:

  • the post is saving
  • the post is not saveable
  • publishing is not allowed
  • the post saving lock is active (e.g., during media uploads)

Changes

  • Simplified isButtonDisabled condition
  • Simplified isToggleDisabled condition
  • Ensured consistent behavior during upload and save states

Testing

  • Ran E2E tests (upload-save-lock.spec.js)
  • Verified that:
    • Save Draft button is disabled during single image upload
    • Save Draft button is disabled during multi-image upload
    • Publish button is disabled during upload
    • Buttons are re-enabled after upload completes

Result

Fixes flaky behavior and ensures UI correctly reflects upload/save lock state.

@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Ashok-A15 <ashokearappa@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added [Package] Editor /packages/editor First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Apr 23, 2026
@github-actions

Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Ashok-A15! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano changed the title ix: ensure Save Draft and Publish buttons are disabled during media upload Fix: ensure Save Draft and Publish buttons are disabled during media upload Apr 27, 2026
@adamsilverstein

Copy link
Copy Markdown
Member

Hi @Ashok-A15 thanks for the bug report. I noticed some tests are failing, can you address that.

Also can you add some testing steps and information about your setup.

@adamsilverstein
adamsilverstein self-requested a review May 6, 2026 17:07
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: [Package] Editor, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@adamsilverstein

Copy link
Copy Markdown
Member

ps. this should have been fixed in #76973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants