Skip to content

UI: Recommend Link component for use #77505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 3 commits into from
Apr 29, 2026
Merged

UI: Recommend Link component for use #77505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bd556e
UI: Recommend Link component for use
mirka Apr 29, 2026
ad35974
Merge branch 'trunk' into update/stabilize-link-component
mirka Apr 29, 2026
0bf8715
Add suppressions
mirka Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/src/external-link/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type { Meta, StoryFn } from '@storybook/react-vite';
import ExternalLink from '..';

const meta: Meta< typeof ExternalLink > = {
tags: [ 'manifest' ],
component: ExternalLink,
title: 'Components/Navigation/ExternalLink',
id: 'components-externallink',
Expand All @@ -22,8 +21,9 @@ const meta: Meta< typeof ExternalLink > = {
},
docs: { canvas: { sourceState: 'shown' } },
componentStatus: {
status: 'stable',
status: 'not-recommended',
whereUsed: 'global',
notes: 'Use `Link` from `@wordpress/ui` instead, with the `openInNewTab` prop set.',
},
},
};
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/rules/use-recommended-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const ALLOWLIST = {
*/
const DENYLIST = {
'@wordpress/components': {
ExternalLink:
'Use `Link` from `@wordpress/ui` with the `openInNewTab` prop instead.',
__experimentalHeading: 'Use `Text` from `@wordpress/ui` instead.',
__experimentalHStack: 'Use `Stack` from `@wordpress/ui` instead.',
__experimentalText: 'Use `Text` from `@wordpress/ui` instead.',
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/link/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Text } from '../../text';
const meta: Meta< typeof Link > = {
title: 'Design System/Components/Link',
component: Link,
tags: [ 'manifest' ],
};
export default meta;

Expand Down
143 changes: 134 additions & 9 deletions tools/eslint/suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
{
"packages/block-directory/src/components/downloadable-blocks-panel/no-results.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-editor/src/components/background-image-control/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
Expand Down Expand Up @@ -96,7 +101,7 @@
},
"packages/block-editor/src/components/date-format-picker/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/block-editor/src/components/global-styles/advanced-panel.js": {
Expand Down Expand Up @@ -139,6 +144,11 @@
"count": 4
}
},
"packages/block-editor/src/components/inserter/block-patterns-tab/patterns-filter.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-editor/src/components/inserter/media-tab/media-preview.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand All @@ -161,7 +171,7 @@
},
"packages/block-editor/src/components/link-control/link-preview.js": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/block-editor/src/components/link-picker/link-preview.js": {
Expand Down Expand Up @@ -195,6 +205,16 @@
}
},
"packages/block-editor/src/components/url-popover/image-url-input-ui.js": {
"@wordpress/use-recommended-components": {
"count": 2
}
},
"packages/block-editor/src/components/url-popover/link-viewer-url.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-editor/src/hooks/anchor.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
Expand All @@ -219,6 +239,11 @@
"count": 1
}
},
"packages/block-library/src/button/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/columns/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand All @@ -229,9 +254,14 @@
"count": 1
}
},
"packages/block-library/src/cover/edit/inspector-controls.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/embed/embed-placeholder.js": {
"@wordpress/use-recommended-components": {
"count": 2
"count": 3
}
},
"packages/block-library/src/html/edit.js": {
Expand All @@ -244,11 +274,21 @@
"count": 2
}
},
"packages/block-library/src/image/image.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/math/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/media-text/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/navigation-link/link-ui/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand Down Expand Up @@ -289,6 +329,16 @@
"count": 2
}
},
"packages/block-library/src/post-featured-image/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/post-title/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/query/edit/enhanced-pagination-modal.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand All @@ -304,11 +354,21 @@
"count": 1
}
},
"packages/block-library/src/rss/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/search/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/social-link/edit.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/block-library/src/template-part/edit/import-controls.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand Down Expand Up @@ -361,7 +421,7 @@
},
"packages/boot/src/components/site-hub/index.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/commands/src/components/command-menu.js": {
Expand All @@ -371,7 +431,12 @@
},
"packages/connectors/src/connector-item.tsx": {
"@wordpress/use-recommended-components": {
"count": 3
"count": 4
}
},
"packages/customize-widgets/src/components/welcome-guide/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/dataviews/src/components/dataform-layouts/panel/dropdown.tsx": {
Expand Down Expand Up @@ -419,6 +484,11 @@
"count": 2
}
},
"packages/edit-post/src/components/welcome-guide/default.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/edit-site/src/components/add-new-post/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
Expand Down Expand Up @@ -509,6 +579,11 @@
"count": 1
}
},
"packages/edit-widgets/src/components/welcome-guide/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/document-bar/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
Expand All @@ -519,6 +594,11 @@
"count": 2
}
},
"packages/editor/src/components/global-styles-sidebar/welcome-guide.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/global-styles/header.js": {
"@wordpress/use-recommended-components": {
"count": 3
Expand All @@ -529,6 +609,11 @@
"count": 1
}
},
"packages/editor/src/components/page-attributes/parent.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/post-actions/set-as-homepage.js": {
"@wordpress/use-recommended-components": {
"count": 3
Expand Down Expand Up @@ -559,6 +644,11 @@
"count": 1
}
},
"packages/editor/src/components/post-excerpt/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/post-excerpt/panel.js": {
"@wordpress/use-recommended-components": {
"count": 2
Expand All @@ -576,7 +666,7 @@
},
"packages/editor/src/components/post-locked-modal/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/editor/src/components/post-panel-row/index.js": {
Expand All @@ -589,6 +679,16 @@
"count": 1
}
},
"packages/editor/src/components/post-pingbacks/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/post-publish-panel/postpublish.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/editor/src/components/post-revisions-panel/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
Expand All @@ -610,6 +710,11 @@
}
},
"packages/editor/src/components/post-url/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
}
},
"packages/editor/src/components/post-url/panel.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
Expand All @@ -631,7 +736,7 @@
},
"packages/editor/src/components/sidebar/post-revision-summary.js": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/editor/src/components/sidebar/post-summary.js": {
Expand Down Expand Up @@ -710,6 +815,11 @@
}
},
"packages/fields/src/fields/excerpt/index.tsx": {
"@wordpress/use-recommended-components": {
"count": 2
}
},
"packages/fields/src/fields/parent/parent-edit.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
}
Expand All @@ -719,14 +829,19 @@
"count": 1
}
},
"packages/fields/src/fields/ping-status/index.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/fields/src/fields/post-content-info/post-content-info-view.tsx": {
"@wordpress/use-recommended-components": {
"count": 2
}
},
"packages/fields/src/fields/slug/slug-edit.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
"count": 2
}
},
"packages/fields/src/fields/status/status-view.tsx": {
Expand All @@ -741,7 +856,7 @@
},
"packages/format-library/src/image/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
"count": 3
}
},
"packages/format-library/src/language/index.js": {
Expand Down Expand Up @@ -889,6 +1004,11 @@
"count": 1
}
},
"packages/global-styles-ui/src/screen-css.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/global-styles-ui/src/screen-header.tsx": {
"@wordpress/use-recommended-components": {
"count": 4
Expand Down Expand Up @@ -999,6 +1119,11 @@
"count": 1
}
},
"routes/connectors-home/ai-plugin-callout.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"routes/connectors-home/default-connectors.tsx": {
"@wordpress/use-recommended-components": {
"count": 1
Expand Down
Loading