Skip to content

LinkPicker: Decode HTML entities in link preview title #77170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 1 commit into from
Apr 9, 2026
Merged

LinkPicker: Decode HTML entities in link preview title #77170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/block-editor/src/components/link-picker/link-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
privateApis as componentsPrivateApis,
} from '@wordpress/components';
import { Icon, chevronDown } from '@wordpress/icons';
import { __unstableStripHTML as stripHTML } from '@wordpress/dom';

/**
* Internal dependencies
Expand Down Expand Up @@ -50,7 +51,7 @@ export function LinkPreview( { title, url, image, badges } ) {
numberOfLines={ 1 }
className="link-preview-button__title"
>
{ title }
{ stripHTML( title ) }

@Mamaduka Mamaduka Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stripHTML removes HTML, but I don't think it decodes the entities.

@t-hamano t-hamano Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think __unstableStripHTML (stripHTML) does decode the entities:

wp.dom.__unstableStripHTML( '<b>Hello &amp; World</b>' )
// => "Hello & World"

@ramonjd ramonjd Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to ask whether we need to do something like decodeEntities( stripHTML( title ) )

@ramonjd ramonjd Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I should have just searched 😄

If we trust fetchLinkSuggestions then maybe no?

https://github.com/WordPress/gutenberg/blob/fix/link-picker-entity/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.ts#L150

@Mamaduka Mamaduka Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. We usually use decodeEntities in the codebase. If it works then why change :D

@t-hamano t-hamano Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My prediction is that if unpredictable HTML might be included, stripHTML might be better than decodeEntities. For example, stripHTML is also used in the post title:

gutenberg/packages/editor/src/components/post-card-panel/index.js

Line 123 in a473a4c

title = stripHTML( postTitle );

If we trust fetchLinkSuggestions then maybe no?

https://github.com/WordPress/gutenberg/blob/fix/link-picker-entity/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.ts#L150

Perhaps fetchLinkSuggestions is intended for search results 🤔

@ramonjd ramonjd Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps fetchLinkSuggestions is intended for search results

Well... there is that too! 😆 Sorry I was in a rabbit hole.

I think with decodeEntities is fine if we're unsure if we're getting entity-encoded values. I just tested and couldn't break it. Not that that means much!

</Truncate>
{ url && (
<Truncate
Expand Down
Loading