Skip to content

Fix component naming and hook wrapper lint errors #77003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manzoorwanijk wants to merge 1 commit into from
Closed

Fix component naming and hook wrapper lint errors #77003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/block-editor/src/components/block-list/block-crash-warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@ const warning = (
</Warning>
);

export default () => warning;
export default function BlockCrashWarning() {
return warning;
}
4 changes: 3 additions & 1 deletion packages/block-editor/src/components/block-list/block-crash-warning.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ const warning = (
/>
);

export default () => warning;
export default function BlockCrashWarning() {
return warning;
}
41 changes: 21 additions & 20 deletions packages/components/src/higher-order/with-focus-outside/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,27 @@ import {
} from '@wordpress/compose';

export default createHigherOrderComponent(
( WrappedComponent ) => ( props ) => {
const [ handleFocusOutside, setHandleFocusOutside ] = useState();
const bindFocusOutsideHandler = useCallback(
( node ) =>
setHandleFocusOutside( () =>
node?.handleFocusOutside
? node.handleFocusOutside.bind( node )
: undefined
),
[]
);
( WrappedComponent ) =>
function WithFocusOutside( props ) {
const [ handleFocusOutside, setHandleFocusOutside ] = useState();
const bindFocusOutsideHandler = useCallback(
( node ) =>
setHandleFocusOutside( () =>
node?.handleFocusOutside
? node.handleFocusOutside.bind( node )
: undefined
),
[]
);

return (
<View { ...useFocusOutside( handleFocusOutside ) }>
<WrappedComponent
ref={ bindFocusOutsideHandler }
{ ...props }
/>
</View>
);
},
return (
<View { ...useFocusOutside( handleFocusOutside ) }>
<WrappedComponent
ref={ bindFocusOutsideHandler }
{ ...props }
/>
</View>
);
},
'withFocusOutside'
);
4 changes: 3 additions & 1 deletion packages/components/src/toolbar/toolbar-button/toolbar-button-container.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
*/
import { View } from 'react-native';

export default ( props ) => <View>{ props.children }</View>;
export default function ToolbarButtonContainer( props ) {
return <View>{ props.children }</View>;
}
4 changes: 3 additions & 1 deletion packages/core-data/src/hooks/use-entity-record.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export default function useEntityRecord< RecordType >(
};
}

export function __experimentalUseEntityRecord(
function useDeprecatedEntityRecord(
kind: string,
name: string,
recordId: any,
Expand All @@ -234,3 +234,5 @@ export function __experimentalUseEntityRecord(
} );
return useEntityRecord( kind, name, recordId, options );
}

export { useDeprecatedEntityRecord as __experimentalUseEntityRecord };
7 changes: 3 additions & 4 deletions packages/core-data/src/hooks/use-resource-permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,12 @@ function useResourcePermissions< IdType = void >(

export default useResourcePermissions;

export function __experimentalUseResourcePermissions(
resource: string,
id?: unknown
) {
function useDeprecatedResourcePermissions( resource: string, id?: unknown ) {
deprecated( `wp.data.__experimentalUseResourcePermissions`, {
alternative: 'wp.data.useResourcePermissions',
since: '6.1',
} );
return useResourcePermissions( resource, id );
}

export { useDeprecatedResourcePermissions as __experimentalUseResourcePermissions };
Loading