Skip to content

Fix navigation block rendering unit test #76685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 2 commits into from
Mar 19, 2026
Merged

Fix navigation block rendering unit test #76685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e681ab
Fix navigation block rendering unit test
t-hamano Mar 19, 2026
b680abd
Remove semicolon
t-hamano Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpunit/blocks/class-wp-navigation-block-renderer-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function test_gutenberg_default_block_is_enclosed_in_li_tags() {
// Invoke the private method.
$result = $method->invoke( $reflection, $navigation_link_block );

$expected = '<li class=" wp-block-navigation-item wp-block-navigation-link"><a class="wp-block-navigation-item__content" href="/hello-world"><span class="wp-block-navigation-item__label">Sample Page</span></a></li>';
$expected = '<li class="wp-block-navigation-item wp-block-navigation-link"><a class="wp-block-navigation-item__content" href="/hello-world"><span class="wp-block-navigation-item__label">Sample Page</span></a></li>';
$this->assertEquals( $expected, $result );
}

Expand Down
4 changes: 2 additions & 2 deletions phpunit/blocks/render-block-navigation-submenu-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function test_should_apply_custom_colors_inherited_from_parent_block_via_
$navigation_submenu_block = new WP_Block( $block, $context );

$this->assertStringContainsString(
'<ul style="color:' . $context['customOverlayTextColor'] . ';background-color:' . $context['customOverlayBackgroundColor'] . ';" class="wp-block-navigation__submenu-container has-text-color has-background">',
'<ul style="color:' . $context['customOverlayTextColor'] . ';background-color:' . $context['customOverlayBackgroundColor'] . '" class="wp-block-navigation__submenu-container has-text-color has-background">',
gutenberg_render_block_core_navigation_submenu(
$navigation_submenu_block->attributes,
array(),
Expand Down Expand Up @@ -159,7 +159,7 @@ public function test_should_apply_mix_of_preset_and_custom_colors_inherited_from
$navigation_submenu_block = new WP_Block( $block, $context );

$this->assertStringContainsString(
'<ul style="background-color:' . $context['customOverlayBackgroundColor'] . ';" class="wp-block-navigation__submenu-container has-text-color has-' . $context['overlayTextColor'] . '-color has-background">',
'<ul style="background-color:' . $context['customOverlayBackgroundColor'] . '" class="wp-block-navigation__submenu-container has-text-color has-' . $context['overlayTextColor'] . '-color has-background">',
gutenberg_render_block_core_navigation_submenu(
$navigation_submenu_block->attributes,
array(),
Expand Down
Loading