Image: Hide 'Set as featured image' for in-editor revisions#76123
Merged
Image: Hide 'Set as featured image' for in-editor revisions#76123
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +18 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Mar 4, 2026
| <Slot | ||
| fillProps={ { | ||
| ...fillProps, | ||
| canEdit, |
Member
Author
There was a problem hiding this comment.
The canEdit value is now available via fillProps, making it easier for other consumers to use the same check.
@ramonjd, I think you're working on similar fixes, which might be useful for your cases as well.
| </BlockSettingsMenuControls> | ||
| ); | ||
| const featuredImageControl = | ||
| ! isDescendentOfQueryLoop && postId && id ? ( |
Member
Author
There was a problem hiding this comment.
I moved this check out of fill rendered, we can avoid rendering the whole component in the Query Loop context.
|
Flaky tests detected in b6475b8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22657211560
|
Mamaduka
added
the
Backport to WP 7.0 Beta/RC
ramonjd
approved these changes
Mar 4, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM - matches the permissions-based stuff for patterns.
| Before | After |
|---|---|
 |
 |
Tested that "Set as featured image" still works outside revisions 👍🏻
Good catch
|
Just curious, does the react native script need modification as well? |
Member
Author
I don't think so. Native app development is on hold for now. |
ellatrix
added
Backport to WP 7.0 Beta/RC
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 4, 2026
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: sidhant-tomar-003 <sidhanttomar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: ab59c5f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #76061.
PR hides the 'Set as featured image' control for the image block when the block can't be edited, for example, when displayed by in-editor revisions.
I understand we're editing the post, not the image itself, but I think the
canEditcheck is still suitable here.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast