Fix: Block style variations not rendering in Site Editor Patterns page#76122
Open
Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Open
Fix: Block style variations not rendering in Site Editor Patterns page#76122Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Block style variations (e.g. the outline button) were not rendering in the Site Editor > Patterns page, they displayed as the default style instead.
Closes #76089
Why?
The
useBlockStyleVariationhook readssettings[globalStylesDataKey]to generate per-block variation CSS viatoStyles({ variationStyles: true }). This Symbol key is set byuseBlockEditorSettingsin the main editor provider path, but the Patterns page uses a separateExperimentalBlockEditorProviderwhose settings are built byusePatternSettings. That function spreads rawstoredSettingsfrom the edit-site store (PHP-initialized, carries no Symbol keys), sosettings[globalStylesDataKey]was alwaysundefined, no variation CSS was ever generated.How?
Pass
mergedConfig.styles(fromuseGlobalStyles(), already used in the same hook) as[ globalStylesDataKey ]in the pattern preview settings. This is the exact same data the main editor path uses.Testing Instructions
Screenshots or screencast