Skip to content

RTC: Implement disconnection debounce after initial connection #76114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chriszarate wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

RTC: Implement disconnection debounce after initial connection #76114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/editor/src/components/sync-connection-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ const { retrySyncConnection } = unlock( coreDataPrivateApis );

// Debounce time for initial disconnected status to allow connection to establish.
const INITIAL_DISCONNECTED_DEBOUNCE_MS = 5000;
const noop = () => {};

// Debounce time for showing the disconnect dialog after the intial connection,
// allowing brief network interruptions to resolve.
const DISCONNECTED_DEBOUNCE_MS = 2000;

/**
* Sync connection modal that displays when any entity reports a disconnection.
Expand Down Expand Up @@ -67,7 +70,6 @@ export function SyncConnectionModal() {
useState( null );
const debounceTimerRef = useRef( null );
// Track whether we've passed the initial load phase.
// Once true, disconnected status will show immediately without debounce.
const hasInitializedRef = useRef( false );

const connectionStatus = connectionState?.status;
Expand All @@ -91,9 +93,13 @@ export function SyncConnectionModal() {
);
};

// Debounce only on first load to allow connection to establish.
// Debounce on first load and after connection is established to allow
// brief network interruptions to resolve.
if ( hasInitializedRef.current ) {
showModal();
debounceTimerRef.current = setTimeout(
showModal,
DISCONNECTED_DEBOUNCE_MS
);
} else {
debounceTimerRef.current = setTimeout(
showModal,
Expand Down Expand Up @@ -142,7 +148,7 @@ export function SyncConnectionModal() {
<Modal
className="editor-sync-connection-modal"
isDismissible={ false }
onRequestClose={ noop }
onRequestClose={ () => {} }
shouldCloseOnClickOutside={ false }
shouldCloseOnEsc={ false }
size="medium"
Expand Down
Loading